-
-
Couldn't load subscription status.
- Fork 1.7k
feat(node): Do not drop 300 and 304 status codes by default #17686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| /** | ||
| * Do not capture spans for incoming HTTP requests with the given status codes. | ||
| * By default, spans with 404 status code are ignored. | ||
| * By default, spans with some 3xx and 4xx status codes are ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super-l: Just to clarify?
| * By default, spans with some 3xx and 4xx status codes are ignored. | |
| * By default, spans with some 3xx and 4xx status codes are ignored (see below). |
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Looking at https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Status#redirection_messages, it seems that we should not filter out 300, 302 and 304 status codes by default:
In contrast, the others seem safe to continue to filter:
eventually it makes sense to unify this between node/node-core, but this should happen when we merge the httpIntegration split PR.